Quantcast

code review on a user story

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

code review on a user story

dasam
This post was updated on .
We would want to track all changes that is done to an user story that we keep in Jira.

Today we integrate Jira and our scm via the sventon plugin which gives us the fileset changes to that particular user story. If we now should code review all these changes we need to open Jira and sonar, then manually search for the file that had the change and mark the section changed for code review for every file.

How about allowing sonar to "auto create" reviews based upon your checkin comment i.e you say in the checkin comment that you worked on ds-34 and it needs to be code reviewsed so you also write "@sonar-codereview" in the checkin comment.

Sonar builds/scans your stuff, marks the files for code review "automagically" and creates new unassigned reviews in sonar. Potentially also creates new issues in Jira if wanted via the new flashy integration in the Jira plugin.

This is not possible today, i am just thinking of hearing if this is good idea or, there is a better way? Btw this is just the way the crucible works that atlassian has, which i must say is a good feature.

Best regards

David
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: code review on a user story

Ann Campbell
There are a lot of moving parts to that. :-)

How about you just tag the code itself with @sonarCodeReview ?

Yes, that would need to be cleaned back out manually, (what effect, if any, would that have on the review that was created when that tag was added?) but it seems a lot simpler and would be open to people who weren't using SCM integration.



On Thu, Jun 28, 2012 at 8:12 AM, dasam <[hidden email]> wrote:
We would want to track all changes that is done to an user stories that we
keep in Jira.

Today we integrate Jira and our scm via the sventon plugin which gives us
the fileset changes to that particular user story. If we now should code
review all these changes we need to open Jira and sonar, then manually
search for the file that had the change and mark the section changed for
code review for every file.

How about allowing sonar to "auto create" reviews based upon your checkin
comment i.e you say in the checkin comment that you worked on ds-34 and it
needs to be code reviewsed so you also write "@sonar-codereview" in the
checkin comment.

Sonar builds/scans your stuff, marks the files for code review
"automagically" and creates new unassigned reviews in sonar. Potentially
also creates new issues in Jira if wanted via the new flashy integration in
the Jira plugin.

This is not possible today, i am just thinking of hearing if this is good
idea or, there is a better way? Btw this is just the way the crucible works
that atlassian has, which i must say is a good feature.

Best regards

David


--
View this message in context: http://sonar.15.n6.nabble.com/code-review-on-a-user-story-tp5000381.html
Sent from the Sonar user mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email





--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: code review on a user story

dasam
I like moving parts, as long as a computer does it for me  :-)

i am open to any sort of integration, i like the way it is now that, i.e. the review tools don't clutter your code with annotations or comments.

Thats why i suggested the check-in comment instead of an annotation in the code, i have no other good suggestion to that.

Otherwise we go into Jira land and have to create an plugin for Jira (or modify the sventon plugin) that allows the files to be tagged for code review and Jira to excecute it into Sonar via the api. Maybe that is an simpler solution actually as its just a checkbox / file and an api call to sonar that schedule it for review.

best regards

David
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: code review on a user story

Freddy Mallet
Hi David,

What you're requesting for is really a changeset code review tool like Crucible or Gerrit and indeed Sonar doesn't provide such feature.

Feel free to vote for or comment http://jira.codehaus.org/browse/SONAR-3426

I agree that such kind of tools are really complementary to Sonar and this could make sense to provide a seamless integration.

Kind regards,
Freddy

-----
Sonar for Continuous Inspection



On Thu, Jun 28, 2012 at 3:11 PM, dasam <[hidden email]> wrote:
I like moving parts, as long as a computer does it for me  :-)

i am open to any sort of integration, i like the way it is now that, i.e.
the review tools don't clutter your code with annotations or comments.

Thats why i suggested the check-in comment instead of an annotation in the
code, i have no other good suggestion to that.

Otherwise we go into Jira land and have to create an plugin for Jira (or
modify the sventon plugin) that allows the files to be tagged for code
review and Jira to excecute it into Sonar via the api. Maybe that is an
simpler solution actually as its just a checkbox / file and an api call to
sonar that schedule it for review.

best regards

David

--
View this message in context: http://sonar.15.n6.nabble.com/code-review-on-a-user-story-tp5000381p5000384.html
Sent from the Sonar user mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: code review on a user story

dasam
Hi Freddy!

I had even commented on it, it now got my vote :-)

feel free to make http://jira.codehaus.org/browse/SONARPLUGINS-2007 an duplicate or similar of that

Best regards

David
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: code review on a user story

Patroklos Papapetrou
Just voted for it David

Really interesting and useful feature request!!
Patroklos

2012/6/29 dasam <[hidden email]>
Hi Freddy!

I had even commented on it, it now got my vote :-)

feel free to make http://jira.codehaus.org/browse/SONARPLUGINS-2007 an
duplicate or similar of that

Best regards

David

--
View this message in context: http://sonar.15.n6.nabble.com/code-review-on-a-user-story-tp5000381p5000411.html
Sent from the Sonar user mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email



Loading...