Quantcast

[sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Evgeny Mandrikov
Hi guys,

I'd like to release Sonar Flex Plugin version 1.1.

This plugin enables analysis of Flex / ActionScript projects into Sonar.

This version removes coupling with Maven, fixes some bugs and provides default SQALE model.
For metrics computation FlexMetrics was fully replaced by our own parser based on SSLR. Current version of parser might be incomplete, however it was successfully tested on as3commons project.

26 issues have been solved
http://jira.codehaus.org/browse/SONARPLUGINS/fixforversion/18370

There are still a couple of issues left

Release early, release often!

--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Fabrice Bellingard-4
+1, I've tested all the tickets!

Congrats for this 1rst version of the SSLR-based parser!


Best regards,

Fabrice BELLINGARD | SonarSource
http://sonarsource.com



On Fri, Jun 15, 2012 at 9:35 AM, Evgeny Mandrikov <[hidden email]> wrote:
Hi guys,

I'd like to release Sonar Flex Plugin version 1.1.

This plugin enables analysis of Flex / ActionScript projects into Sonar.

This version removes coupling with Maven, fixes some bugs and provides default SQALE model.
For metrics computation FlexMetrics was fully replaced by our own parser based on SSLR. Current version of parser might be incomplete, however it was successfully tested on as3commons project.

26 issues have been solved
http://jira.codehaus.org/browse/SONARPLUGINS/fixforversion/18370

There are still a couple of issues left

Release early, release often!

--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Eriks Nukis
In reply to this post by Evgeny Mandrikov
Hi,

I happened to have  https://github.com/Worlize/AS3WebSocket in my sources on which plugin failed with exception (log with AS3WebSocket analysed separately attached). After removing  AS3WebSocket, remaining sources were analysed with couple parsing issues.

Otherwise looks good, +0.

Regards,
E.







On Fri, Jun 15, 2012 at 10:35 AM, Evgeny Mandrikov <[hidden email]> wrote:
Hi guys,

I'd like to release Sonar Flex Plugin version 1.1.

This plugin enables analysis of Flex / ActionScript projects into Sonar.

This version removes coupling with Maven, fixes some bugs and provides default SQALE model.
For metrics computation FlexMetrics was fully replaced by our own parser based on SSLR. Current version of parser might be incomplete, however it was successfully tested on as3commons project.

26 issues have been solved
http://jira.codehaus.org/browse/SONARPLUGINS/fixforversion/18370

There are still a couple of issues left

Release early, release often!

--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

log.txt (11K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Alexandre Victoor-2
In reply to this post by Evgeny Mandrikov

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Evgeny Mandrikov
Hi Eriks and Victoor,

First of all - thanks for your tests.
I'm pretty sure that you face the same issue and I'll dig into it as soon as possible.

On Mon, Jun 18, 2012 at 6:43 PM, Alexandre Victoor <[hidden email]> wrote:

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex




--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Evgeny Mandrikov
Hi Eriks and Victoor,

Could you please confirm that if you'll disable rule "Avoid too complex function", then this problem disappears ?

On Mon, Jun 18, 2012 at 6:48 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Eriks and Victoor,

First of all - thanks for your tests.
I'm pretty sure that you face the same issue and I'll dig into it as soon as possible.


On Mon, Jun 18, 2012 at 6:43 PM, Alexandre Victoor <[hidden email]> wrote:

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex




--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Evgeny Mandrikov
FYI problem should be fixed and new snapshot available.

On Tue, Jun 19, 2012 at 11:47 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Eriks and Victoor,

Could you please confirm that if you'll disable rule "Avoid too complex function", then this problem disappears ?


On Mon, Jun 18, 2012 at 6:48 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Eriks and Victoor,

First of all - thanks for your tests.
I'm pretty sure that you face the same issue and I'll dig into it as soon as possible.


On Mon, Jun 18, 2012 at 6:43 PM, Alexandre Victoor <[hidden email]> wrote:

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex




--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Alexandre Victoor-2
In reply to this post by Evgeny Mandrikov

Sorry for the late response, I was away from my computer all day long.
I confirm it works when this rule is disabled.
There is something else that looks strange. The copy/paste detector seems to be a little bit too sensitive. In mxml files, xml namespaces declarations and packages import statements seem to be taken in account.
Regards

Alex

Ps: Victoor is my lastname ;-)

Le 19 juin 2012 19:47, "Evgeny Mandrikov" <[hidden email]> a écrit :
Hi Eriks and Victoor,

Could you please confirm that if you'll disable rule "Avoid too complex function", then this problem disappears ?

On Mon, Jun 18, 2012 at 6:48 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Eriks and Victoor,

First of all - thanks for your tests.
I'm pretty sure that you face the same issue and I'll dig into it as soon as possible.


On Mon, Jun 18, 2012 at 6:43 PM, Alexandre Victoor <[hidden email]> wrote:

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex




--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Evgeny Mandrikov
Hi,

See my comments below :

On Wed, Jun 20, 2012 at 10:22 PM, Alexandre Victoor <[hidden email]> wrote:

Sorry for the late response, I was away from my computer all day long.

No pb. 

I confirm it works when this rule is disabled.

Now it should work even with this rule. 

There is something else that looks strange. The copy/paste detector seems to be a little bit too sensitive. In mxml files, xml namespaces declarations and packages import statements seem to be taken in account.

In fact according to the ticket SONARPLUGINS-1965 detection should not occur for mxml at all.

Regards

Alex

Ps: Victoor is my lastname ;-)

Sorry - I don't know why, but I always do this mistake :( 

Le 19 juin 2012 19:47, "Evgeny Mandrikov" <[hidden email]> a écrit :

Hi Eriks and Victoor,

Could you please confirm that if you'll disable rule "Avoid too complex function", then this problem disappears ?

On Mon, Jun 18, 2012 at 6:48 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Eriks and Victoor,

First of all - thanks for your tests.
I'm pretty sure that you face the same issue and I'll dig into it as soon as possible.


On Mon, Jun 18, 2012 at 6:43 PM, Alexandre Victoor <[hidden email]> wrote:

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex




--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Evgeny Mandrikov
Hi Victoor,

I disabled duplication detection in mxml files until resolution of SONARPLUGINS-1965 : https://github.com/SonarCommunity/sonar-flex/commit/9f16c42c52f10b1a84483b321932d06b3683e623

On Thu, Jun 21, 2012 at 11:32 AM, Evgeny Mandrikov <[hidden email]> wrote:
Hi,

See my comments below :

On Wed, Jun 20, 2012 at 10:22 PM, Alexandre Victoor <[hidden email]> wrote:

Sorry for the late response, I was away from my computer all day long.

No pb. 

I confirm it works when this rule is disabled.

Now it should work even with this rule. 

There is something else that looks strange. The copy/paste detector seems to be a little bit too sensitive. In mxml files, xml namespaces declarations and packages import statements seem to be taken in account.

In fact according to the ticket SONARPLUGINS-1965 detection should not occur for mxml at all.

Regards

Alex

Ps: Victoor is my lastname ;-)

Sorry - I don't know why, but I always do this mistake :( 

Le 19 juin 2012 19:47, "Evgeny Mandrikov" <[hidden email]> a écrit :

Hi Eriks and Victoor,

Could you please confirm that if you'll disable rule "Avoid too complex function", then this problem disappears ?

On Mon, Jun 18, 2012 at 6:48 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Eriks and Victoor,

First of all - thanks for your tests.
I'm pretty sure that you face the same issue and I'll dig into it as soon as possible.


On Mon, Jun 18, 2012 at 6:43 PM, Alexandre Victoor <[hidden email]> wrote:

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex




--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[sonar-dev] [RESULT] [VOTE] Release Sonar Flex Plugin 1.1

Evgeny Mandrikov
In reply to this post by Evgeny Mandrikov
Hi,

The vote has passed with lazy consensus with the following result:
+1 : Fabrice Bellingard
+0 : Eriks Nukis, Alexandre Victoor

Thanks for your feedback and tests. I will continue with the release.


--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Evgeny Mandrikov
In reply to this post by Evgeny Mandrikov
And sorry for my mistake again :)))

On Mon, Jun 25, 2012 at 6:04 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Victoor,

I disabled duplication detection in mxml files until resolution of SONARPLUGINS-1965 : https://github.com/SonarCommunity/sonar-flex/commit/9f16c42c52f10b1a84483b321932d06b3683e623

On Thu, Jun 21, 2012 at 11:32 AM, Evgeny Mandrikov <[hidden email]> wrote:
Hi,

See my comments below :

On Wed, Jun 20, 2012 at 10:22 PM, Alexandre Victoor <[hidden email]> wrote:

Sorry for the late response, I was away from my computer all day long.

No pb. 

I confirm it works when this rule is disabled.

Now it should work even with this rule. 

There is something else that looks strange. The copy/paste detector seems to be a little bit too sensitive. In mxml files, xml namespaces declarations and packages import statements seem to be taken in account.

In fact according to the ticket SONARPLUGINS-1965 detection should not occur for mxml at all.

Regards

Alex

Ps: Victoor is my lastname ;-)

Sorry - I don't know why, but I always do this mistake :( 

Le 19 juin 2012 19:47, "Evgeny Mandrikov" <[hidden email]> a écrit :

Hi Eriks and Victoor,

Could you please confirm that if you'll disable rule "Avoid too complex function", then this problem disappears ?

On Mon, Jun 18, 2012 at 6:48 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Eriks and Victoor,

First of all - thanks for your tests.
I'm pretty sure that you face the same issue and I'll dig into it as soon as possible.


On Mon, Jun 18, 2012 at 6:43 PM, Alexandre Victoor <[hidden email]> wrote:

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex




--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] [VOTE] Release Sonar Flex Plugin 1.1

Freddy Mallet
Victoor could you get out of Alexandre's body ? :D



On Mon, Jun 25, 2012 at 2:11 PM, Evgeny Mandrikov <[hidden email]> wrote:
And sorry for my mistake again :)))


On Mon, Jun 25, 2012 at 6:04 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Victoor,

I disabled duplication detection in mxml files until resolution of SONARPLUGINS-1965 : https://github.com/SonarCommunity/sonar-flex/commit/9f16c42c52f10b1a84483b321932d06b3683e623

On Thu, Jun 21, 2012 at 11:32 AM, Evgeny Mandrikov <[hidden email]> wrote:
Hi,

See my comments below :

On Wed, Jun 20, 2012 at 10:22 PM, Alexandre Victoor <[hidden email]> wrote:

Sorry for the late response, I was away from my computer all day long.

No pb. 

I confirm it works when this rule is disabled.

Now it should work even with this rule. 

There is something else that looks strange. The copy/paste detector seems to be a little bit too sensitive. In mxml files, xml namespaces declarations and packages import statements seem to be taken in account.

In fact according to the ticket SONARPLUGINS-1965 detection should not occur for mxml at all.

Regards

Alex

Ps: Victoor is my lastname ;-)

Sorry - I don't know why, but I always do this mistake :( 

Le 19 juin 2012 19:47, "Evgeny Mandrikov" <[hidden email]> a écrit :

Hi Eriks and Victoor,

Could you please confirm that if you'll disable rule "Avoid too complex function", then this problem disappears ?

On Mon, Jun 18, 2012 at 6:48 PM, Evgeny Mandrikov <[hidden email]> wrote:
Hi Eriks and Victoor,

First of all - thanks for your tests.
I'm pretty sure that you face the same issue and I'll dig into it as soon as possible.


On Mon, Jun 18, 2012 at 6:43 PM, Alexandre Victoor <[hidden email]> wrote:

Hello
I have tried the plugin on a real life project. The analysis fails. Below the stack trace:

> Caused by: org.sonar.squid.api.AnalysisException: Sonar is unable to analyze file : 'C:\SOMEPATH\Propagate.as'
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:151)
>        at org.sonar.plugins.flex.FlexSquidSensor.analyse(FlexSquidSensor.java:93)
>        at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:64)
>        at org.sonar.batch.phases.Phases.execute(Phases.java:93)
>        at org.sonar.batch.bootstrap.ProjectModule.doStart(ProjectModule.java:139)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:115)
>        at org.sonar.batch.bootstrap.BatchModule.analyze(BatchModule.java:110)
>        at org.sonar.batch.bootstrap.BatchModule.doStart(BatchModule.java:105)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrap.BootstrapModule.doStart(BootstrapModule.java:111)
>        at org.sonar.batch.bootstrap.Module.start(Module.java:83)
>        at org.sonar.batch.bootstrapper.Batch.startBatch(Batch.java:73)
>        at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:60)
>        at org.sonar.maven3.SonarMojo.execute(SonarMojo.java:142)
>        at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:113)
>        ... 23 more
> Caused by: java.lang.ClassCastException: org.sonar.squid.api.SourceClass cannot be cast to org.sonar.squid.api.SourceFunction
>        at org.sonar.flex.checks.FunctionComplexityCheck.leaveNode(FunctionComplexityCheck.java:52)
>        at com.sonar.sslr.impl.ast.AstWalker.leaveNode(AstWalker.java:81)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:76)
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        …
>        at com.sonar.sslr.impl.ast.AstWalker.visitChildren(AstWalker.java:89)
>        at com.sonar.sslr.impl.ast.AstWalker.visit(AstWalker.java:75)
>        at com.sonar.sslr.impl.ast.AstWalker.walkVisitAndListen(AstWalker.java:65)
>        at com.sonar.sslr.impl.ast.AstWalker.walkAndVisit(AstWalker.java:58)
>        at com.sonar.sslr.squid.AstScanner.scanFiles(AstScanner.java:110)
>        ... 38 more

I took a quick glance at “Propagate.as” source file. Nothing special except the  the asdoc comments  contains a block of code inside a “<pre>” tag.
IMHO if this parsing error is not fixed for this release, it would be nice if it would be nice to make it not fatal.
Regards

Alex




--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_



--
Best regards,
Evgeny Mandrikov aka Godin <http://godin.net.ru>
http://twitter.com/_godin_

Loading...