Quantcast

[sonar-dev] beta review API

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[sonar-dev] beta review API

Ann Campbell
I'm finally able to work with the beta Reviews API & it mostly seems straightforward, but there's one thing I'm missing: 

How do I set the "pretty" label for the link that gets added to the "More actions" reviews dropdown and/or the submit button for the form? What I'm currently seeing is:
reviews.command.[my workflow command(?)].button 

as the link label in the dropdown, and
reviews.command.[my workflow.command].submit

as the button label.

My workflow starts like this:

  public void start() {
    workflow.addCommand(LINK_TO_CP_ID);
    workflow.setScreen(LINK_TO_CP_ID, new CommentScreen());
    workflow.addFunction(LINK_TO_CP_ID, linkFunction);

    // conditions here...


BTW, love the easy condition checking!


Thx,
Ann

--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] beta review API

Fabrice Bellingard-4
Hi Ann,

you have to define a properties file (= a bundle for the I18n mechanism) where you will define your labels using the naming convention that you mentioned.

As a comparison, here is the default bundle that defines the labels for the JIRA plugin: https://svn.codehaus.org/sonar-plugins/trunk/jira/src/main/resources/org/sonar/l10n/jira.properties

HTH!

Best regards,

Fabrice BELLINGARD | SonarSource
http://sonarsource.com



On Mon, Jun 25, 2012 at 11:30 PM, Ann Campbell <[hidden email]> wrote:
I'm finally able to work with the beta Reviews API & it mostly seems straightforward, but there's one thing I'm missing: 

How do I set the "pretty" label for the link that gets added to the "More actions" reviews dropdown and/or the submit button for the form? What I'm currently seeing is:
reviews.command.[my workflow command(?)].button 

as the link label in the dropdown, and
reviews.command.[my workflow.command].submit

as the button label.

My workflow starts like this:

  public void start() {
    workflow.addCommand(LINK_TO_CP_ID);
    workflow.setScreen(LINK_TO_CP_ID, new CommentScreen());
    workflow.addFunction(LINK_TO_CP_ID, linkFunction);

    // conditions here...


BTW, love the easy condition checking!


Thx,
Ann

--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] beta review API

Ann Campbell
Thanks Fabrice!

l18n hadn't occurred to me since this is an internal plugin (no one else would want it :-) for an English-only crowd!

I found the wiki doc for I18n pretty easily, but it took me a while to figure out what my plugin key was. This doc: http://docs.codehaus.org/display/SONAR/sonar-packaging-maven-plugin only says it's "constructed from" the artifact id, but not how. Clearly I'm a little dense because everyone else seems to have figured that part out easily. But an expansion in the docs might be helpful.

I'd do the edits, but I'm not sure how y'all feel about non-staff updating anything but the plugin pages...


On Tue, Jun 26, 2012 at 8:19 AM, Fabrice Bellingard <[hidden email]> wrote:
Hi Ann,

you have to define a properties file (= a bundle for the I18n mechanism) where you will define your labels using the naming convention that you mentioned.

As a comparison, here is the default bundle that defines the labels for the JIRA plugin: https://svn.codehaus.org/sonar-plugins/trunk/jira/src/main/resources/org/sonar/l10n/jira.properties

HTH!

Best regards,

Fabrice BELLINGARD | SonarSource
http://sonarsource.com



On Mon, Jun 25, 2012 at 11:30 PM, Ann Campbell <[hidden email]> wrote:
I'm finally able to work with the beta Reviews API & it mostly seems straightforward, but there's one thing I'm missing: 

How do I set the "pretty" label for the link that gets added to the "More actions" reviews dropdown and/or the submit button for the form? What I'm currently seeing is:
reviews.command.[my workflow command(?)].button 

as the link label in the dropdown, and
reviews.command.[my workflow.command].submit

as the button label.

My workflow starts like this:

  public void start() {
    workflow.addCommand(LINK_TO_CP_ID);
    workflow.setScreen(LINK_TO_CP_ID, new CommentScreen());
    workflow.addFunction(LINK_TO_CP_ID, linkFunction);

    // conditions here...


BTW, love the easy condition checking!


Thx,
Ann

--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************





--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] beta review API

Fabrice Bellingard-4
On Tue, Jun 26, 2012 at 3:05 PM, Ann Campbell <[hidden email]> wrote:
Thanks Fabrice!

l18n hadn't occurred to me since this is an internal plugin (no one else would want it :-) for an English-only crowd!

Yes, that's true :-)
 
I found the wiki doc for I18n pretty easily, but it took me a while to figure out what my plugin key was. This doc: http://docs.codehaus.org/display/SONAR/sonar-packaging-maven-plugin only says it's "constructed from" the artifact id, but not how. Clearly I'm a little dense because everyone else seems to have figured that part out easily. But an expansion in the docs might be helpful.

I totally agree on this point, some extra explanations are missing on this topic. 
 
I'd do the edits, but I'm not sure how y'all feel about non-staff updating anything but the plugin pages...

Well, Ann, looking at your involvement in the community and the project, I don't think any of us would wince if you edited pages other than the plugin pages. We all get notifications when there are changes on the Wiki, so we can control if what is added is correct or not. What's more, if you make edits after a thread discussion like this one where you've learnt something that the documentation did not provide, this is just the perfect example of doc contribution IMO. 

 


On Tue, Jun 26, 2012 at 8:19 AM, Fabrice Bellingard <[hidden email]> wrote:
Hi Ann,

you have to define a properties file (= a bundle for the I18n mechanism) where you will define your labels using the naming convention that you mentioned.

As a comparison, here is the default bundle that defines the labels for the JIRA plugin: https://svn.codehaus.org/sonar-plugins/trunk/jira/src/main/resources/org/sonar/l10n/jira.properties

HTH!

Best regards,

Fabrice BELLINGARD | SonarSource
http://sonarsource.com



On Mon, Jun 25, 2012 at 11:30 PM, Ann Campbell <[hidden email]> wrote:
I'm finally able to work with the beta Reviews API & it mostly seems straightforward, but there's one thing I'm missing: 

How do I set the "pretty" label for the link that gets added to the "More actions" reviews dropdown and/or the submit button for the form? What I'm currently seeing is:
reviews.command.[my workflow command(?)].button 

as the link label in the dropdown, and
reviews.command.[my workflow.command].submit

as the button label.

My workflow starts like this:

  public void start() {
    workflow.addCommand(LINK_TO_CP_ID);
    workflow.setScreen(LINK_TO_CP_ID, new CommentScreen());
    workflow.addFunction(LINK_TO_CP_ID, linkFunction);

    // conditions here...


BTW, love the easy condition checking!


Thx,
Ann

--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************





--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [sonar-dev] beta review API

Ann Campbell
Cool. Thanks for the vote of confidence!

Wiki edited. :-)


On Tue, Jun 26, 2012 at 9:54 AM, Fabrice Bellingard <[hidden email]> wrote:
On Tue, Jun 26, 2012 at 3:05 PM, Ann Campbell <[hidden email]> wrote:
Thanks Fabrice!

l18n hadn't occurred to me since this is an internal plugin (no one else would want it :-) for an English-only crowd!

Yes, that's true :-)
 
I found the wiki doc for I18n pretty easily, but it took me a while to figure out what my plugin key was. This doc: http://docs.codehaus.org/display/SONAR/sonar-packaging-maven-plugin only says it's "constructed from" the artifact id, but not how. Clearly I'm a little dense because everyone else seems to have figured that part out easily. But an expansion in the docs might be helpful.

I totally agree on this point, some extra explanations are missing on this topic. 
 
I'd do the edits, but I'm not sure how y'all feel about non-staff updating anything but the plugin pages...

Well, Ann, looking at your involvement in the community and the project, I don't think any of us would wince if you edited pages other than the plugin pages. We all get notifications when there are changes on the Wiki, so we can control if what is added is correct or not. What's more, if you make edits after a thread discussion like this one where you've learnt something that the documentation did not provide, this is just the perfect example of doc contribution IMO. 

 


On Tue, Jun 26, 2012 at 8:19 AM, Fabrice Bellingard <[hidden email]> wrote:
Hi Ann,

you have to define a properties file (= a bundle for the I18n mechanism) where you will define your labels using the naming convention that you mentioned.

As a comparison, here is the default bundle that defines the labels for the JIRA plugin: https://svn.codehaus.org/sonar-plugins/trunk/jira/src/main/resources/org/sonar/l10n/jira.properties

HTH!

Best regards,

Fabrice BELLINGARD | SonarSource
http://sonarsource.com



On Mon, Jun 25, 2012 at 11:30 PM, Ann Campbell <[hidden email]> wrote:
I'm finally able to work with the beta Reviews API & it mostly seems straightforward, but there's one thing I'm missing: 

How do I set the "pretty" label for the link that gets added to the "More actions" reviews dropdown and/or the submit button for the form? What I'm currently seeing is:
reviews.command.[my workflow command(?)].button 

as the link label in the dropdown, and
reviews.command.[my workflow.command].submit

as the button label.

My workflow starts like this:

  public void start() {
    workflow.addCommand(LINK_TO_CP_ID);
    workflow.setScreen(LINK_TO_CP_ID, new CommentScreen());
    workflow.addFunction(LINK_TO_CP_ID, linkFunction);

    // conditions here...


BTW, love the easy condition checking!


Thx,
Ann

--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************





--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************





--
G. Ann Campbell
Sr. Systems Engineer, IS Production Systems - Shop Floor Systems
Shaw Industries Inc,
201 S. Hamilton St.
Dalton Ga 30720


**********************************************************
Privileged and/or confidential information may be contained in this message. If you are not the addressee indicated in this message (or are not responsible for delivery of this message to that person) , you may not copy or deliver this message to anyone. In such case, you should destroy this message and notify the sender by reply e-mail.
If you or your employer do not consent to Internet e-mail for messages of this kind, please advise the sender.
Shaw Industries does not provide or endorse any opinions, conclusions or other information in this message that do not relate to the official business of the company  or its subsidiaries.
**********************************************************

Loading...